Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of not being able to disconnect OAuth2 user #6869

Merged

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

This PR corrects typo of apisGroups to apiGroups to fix the problem of not being able to disconnect OAuth2 user.

Special notes for your reviewer:

  1. Install OAuth2 plugin
  2. Log in as a normal user
  3. Bind a OAuth2 user
  4. Try to unbind it

Does this PR introduce a user-facing change?

修复无法正常解绑 OAuth2 用户

Signed-off-by: JohnNiang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 15, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Oct 15, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 15, 2024
Copy link

sonarcloud bot commented Oct 15, 2024

@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG October 15, 2024 07:46
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2024
Copy link

f2c-ci-robot bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.99%. Comparing base (eff73dc) to head (1bf4466).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6869   +/-   ##
=========================================
  Coverage     56.99%   56.99%           
- Complexity     3999     4005    +6     
=========================================
  Files           714      714           
  Lines         24110    24174   +64     
  Branches       1585     1593    +8     
=========================================
+ Hits          13742    13779   +37     
- Misses         9756     9780   +24     
- Partials        612      615    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit c3020d6 into halo-dev:main Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants